[syslinux] [PATCH 2/4] 4k_sector: Save some bytes adding a function to set bx before read_sector

Matt Fleming matt at console-pimps.org
Mon Feb 11 04:34:34 PST 2013


On Mon, 11 Feb, at 12:28:01PM, Matt Fleming wrote:
> On Fri, 08 Feb, at 12:58:34PM, Frediano Ziglio wrote:
> > Mostly of the time bx was set as phdr before calling read_sector
> > so add a specific function to set %bx and call read_sector
> > gaining 2 bytes
> > 
> > Signed-off-by: Frediano Ziglio <frediano.ziglio at citrix.com>
> > ---
> >  mbr/gptmbr.S |   12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> After a couple of times reviewing this, I think I've finally convinced
> myself that this safe. Applied to the elflink branch.

Actually, this comment wants deleting too,

	/* Note: phdr == 6(%bp) */

since the phdr pointer is no longer on the stack. I'll take care of
fixing this up, don't bother resending.
-- 
Matt Fleming, Intel Open Source Technology Center


More information about the Syslinux mailing list