[syslinux] [syslinux:firmware] vesa: Correct screencpy() prototype

H. Peter Anvin hpa at zytor.com
Wed Jan 9 14:19:11 PST 2013


On 01/07/2013 12:51 PM, syslinux-bot for Matt Fleming wrote:
> Commit-ID:  15a67011987c341814533ac4d8e23c9a72dc7605
> Gitweb:     http://www.syslinux.org/commit/15a67011987c341814533ac4d8e23c9a72dc7605
> Author:     Matt Fleming <matt.fleming at intel.com>
> AuthorDate: Mon, 7 Jan 2013 14:42:16 +0000
> Committer:  Matt Fleming <matt.fleming at intel.com>
> CommitDate: Mon, 7 Jan 2013 20:29:16 +0000
> 
> vesa: Correct screencpy() prototype
> 
> The 'src' argument should actually be const char * because the BIOS
> code performs pointer arithmetic on it.
> 
> Signed-off-by: Matt Fleming <matt.fleming at intel.com>
> 

Not really.

The objects are uint32_t and so the prototype is correct.  It should not
"leak" outside the screencpy function that we play ugly tricks with
these pointers; that is better handled by an internal cast.

	-hpa




More information about the Syslinux mailing list