[syslinux] [bug] Syslinux-5.11-pre2: IPAPPEND/SYSAPPEND inconsistent base

[Gene Cumm]

On Sun, Jun 23, 2013 at 11:09 PM, Gene Cumm <gene.cumm at gmail.com> wrote:
> On Sun, Jun 23, 2013 at 11:06 PM, Gene Cumm <gene.cumm at gmail.com> wrote:
>> core and the simple menu do not interpret the IPAPPEND/SYSAPPEND
>> directives in the same way.  Which is the proper way?  Either way,
>> this should be clarified in the documentation.
>
> To be clear: core treats the value as always hexidecimal while simple
> menu treats it as decimal unless a 0x prefix is present.

Correction: simple menu always does decimal (as should be expected).

>> com32/elflink/ldlinux/readconfig.c:
>>         } else if ((ep = looking_at(p, "ipappend")) ||
>>                 (ep = looking_at(p, "sysappend"))) {
>>             uint32_t s = strtoul(skipspace(ep), NULL, 16);
>>             if (ld.label)
>>                 ld.ipappend = s;
>>             else
>>                 SysAppends = s;
>>
>> com32/menu/readconfig.c
>>         } else if ((ep = looking_at(p, "ipappend")) || (ep =
>> looking_at(p, "sysappend"))) {
>>             if (ld.label)
>>                 ld.ipappend = atoi(skipspace(ep));
>>             else
>>                 ipappend = atoi(skipspace(ep));
>>
>> --
>> -Gene