[syslinux] [bug] Syslinux-5.11-pre2: IPAPPEND/SYSAPPEND inconsistent base

[H. Peter Anvin]

It is wrong, but it wasn't decimal either.  The right answer is to use strtoul with a base of 0.

Matt Fleming <matt at console-pimps.org> wrote:

>On Sun, 23 Jun, at 11:21:45PM, Gene Cumm wrote:
>> Correction: simple menu always does decimal (as should be expected).
>> 
>> >> com32/elflink/ldlinux/readconfig.c:
>> >>         } else if ((ep = looking_at(p, "ipappend")) ||
>> >>                 (ep = looking_at(p, "sysappend"))) {
>> >>             uint32_t s = strtoul(skipspace(ep), NULL, 16);
>> >>             if (ld.label)
>> >>                 ld.ipappend = s;
>> >>             else
>> >>                 SysAppends = s;
> 
>This looks incorrect to me, and is likely a regression in the 5.x code.
>It appears as though the 4.x parser treated the ipappend string as
>decimal.
>
>Peter, does this look incorrect to you too? The com32/menu code gets
>this right.

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.