[syslinux] Syslinux-5.10-pre1 looks for ldlinux.c32 in TFTP instead of HTTP

[Matt Fleming]

On Fri, 2013-03-08 at 14:17 +0100, Tobias Göbel wrote:
> Got it!

Excellent, thank you for doing this.

> I think it's some sort of win-win situation. Learned something and found 
> the commit that causes the error... I think git bisect will be my tool 
> of the month :)

Hehe, yes, it is a very neat tool.

[...]

> # git bisect good
> b208ba467f678ed8e73f8d11fc0609634120cb83 is the first bad commit
> commit b208ba467f678ed8e73f8d11fc0609634120cb83
> Author: Matt Fleming <matt.fleming at intel.com>
> Date:   Tue Feb 19 21:09:55 2013 +0000
> 
>      pxe: Pass absolute path to pxe_chdir()
> 
>      We may have moved out of the root directory when calling get_prefix()
>      and so need a way to create an absolute path.
> 
>      Historically, in versions prior to 5.xx we would call
>      pxe_open_config() while we were still in the root directory ("::"),
>      and so, we could construct a relative path to the config file.
> 
>      However, because we need to load ldlinux.c32 before opening the config
>      file, which may involve us changing directory, we need a way of
>      constructing an absolute path to the config file in get_prefix().
> 
>      Signed-off-by: Matt Fleming <matt.fleming at intel.com>
> 
> :040000 040000 a3fe656d40834a6379d166f9134acb574bbde05a 
> d52b7d5448adcea31a5e55a29b48548fa6ee910b M      core

Crap. This is one of those areas of Syslinux where every change tends to
break something else. Thanks, I'll cook up a patch to fix this.

Also, as a general rule, and just to be absolutely positive that your
git bisect can be trusted, it's a good idea to revert the offending
commit and make sure your problem goes away.

So, something like,

   1. git reset --hard syslinux-5.02-pre3
   2. git revert b208ba467f678ed8e73f8d11fc0609634120cb83
   3. make spotless all

*should* result in a working pxelinux.0.

-- 
Matt Fleming, Intel Open Source Technology Center