[syslinux] Makefile race condition with parallel make
H. Peter Anvin
hpa at zytor.com
Thu Mar 28 14:00:18 PDT 2013
On 03/28/2013 01:30 PM, Josh Triplett wrote:
> On Thu, Mar 28, 2013 at 01:10:51PM -0700, Josh Triplett wrote:
>> On Thu, Mar 28, 2013 at 12:12:44PM -0700, H. Peter Anvin wrote:
>>> I think this patch should disentangle the dependencies by avoiding the
>>> need for IS_LPXELINUX.
>>> Please let me know if it works for you.
>> I can't reliably reproduce the race in the unpatched version (I've only
>> ever seen it once), but this builds for me, and by inspection it
>> definitely fixes the race I observed.
>> Reviewed-by: Josh Triplett <josh at joshtriplett.org>
> I ran "make -j" on syslinux with and without this patch a few hundred
> times, and I did manage to reproduce this race one more time on the
> unpatched version, while never reproducing it on the patched version.
> I've attached a full log from the failed build for reference; the log
> definitely agrees with the analysis and fix.
And the output works for you? ;)
More information about the Syslinux