[syslinux] [PATCH 3/4 v2] com32: Fix bugs on cmd_reverse_search (Triple fault dimension)

Matt Fleming matt at console-pimps.org
Mon Sep 30 07:17:36 PDT 2013


On Tue, 17 Sep, at 04:48:58PM, Raphael S.Carvalho wrote:
> cmd_reverse_search has a bug that the variable cursor is updated even if a command
> wasn't found. If this happens, and the next key falls into the default case,
> memmove's size parameter would be a negative number.
> 
> This bug can be reproduced by doing the following:
> On cmd_reverse_search (ctrl-r), type multiple keys at the same time.
> 'Enjoy' the triple fault and a screen of random colors.
> 
> There is also a small bug that turns the task of using (ctrl-r) on the first command
> impossible. Previously, this command was discarded.
> 
> Signed-off-by: Raphael S.Carvalho <raphael.scarv at gmail.com>
> ---
>  com32/elflink/ldlinux/cli.c |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Matt Fleming, Intel Open Source Technology Center


More information about the Syslinux mailing list