[syslinux] [PATCH 1/4 v2] com32/lib/: Avoid unneeded allocation.
Raphael S Carvalho
raphael.scarv at gmail.com
Mon Sep 30 10:04:17 PDT 2013
>
> It would be better to move the lfree(), and in fact the declaration of
> 'eparam' under...
>
> if (diskbios->ebios) {
> struct disk_ebios_eparam *eparam;
>
> eparam = lmalloc();
>
> ...
>
> lfree(eparam);
> }
>
> since it's not used anywhere else. Make sense?
>
> --
> Matt Fleming, Intel Open Source Technology Center
Agreed. I will resend it with this change.
I initially thought it would be later used by inreg on __intcall, but
inreg is cleaned before __intcall is used again.
Regards,
Raphael S. Carvalho.
More information about the Syslinux
mailing list