[syslinux] [PATCH] check-gnu-efi.sh: print the output of build-gnu-efi.sh

Gene Cumm gene.cumm at gmail.com
Mon Dec 22 13:51:19 PST 2014


On Mon, Nov 24, 2014 at 2:36 AM, Robert Yang <liezhi.yang at windriver.com> wrote:
> The build would be failed and exit if build-gnu-efi.sh is failed, so
> we'd better not suppress the output of build-gnu-efi.sh, which is good
> for debugging.
>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
>  efi/check-gnu-efi.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/efi/check-gnu-efi.sh b/efi/check-gnu-efi.sh
> index 85305f8..7d99e9a 100755
> --- a/efi/check-gnu-efi.sh
> +++ b/efi/check-gnu-efi.sh
> @@ -25,7 +25,7 @@ if [ ! \( -f "$objdir/include/efi/$ARCH/efibind.h" -a -f "$objdir/lib/libefi.a"
>      # Syslinux disables built-in implicit rules.
>      export MAKEFLAGS=
>
> -    ../../efi/build-gnu-efi.sh $ARCH "$objdir" > /dev/null 2>&1
> +    ../../efi/build-gnu-efi.sh $ARCH "$objdir"
>      if [ $? -ne 0 ]; then
>         printf "Failed to build gnu-efi. "
>         printf "Execute the following command for full details: \n\n"

Commit 6e832106 which originally created the shell scripts was the
first instance of this silencing.

Aside from adding a few hundred lines of build output (which could be
beneficial), is there any reason not to remove the null redirects?

-- 
-Gene


More information about the Syslinux mailing list