[syslinux] missing strlcpy fix (which klibc has)

[H. Peter Anvin]

On 07/21/2014 08:11 AM, Ferenc Wagner wrote:
> Ady <ady-sf at hotmail.com> writes:
> 
>>> The current strlcpy code in the Syslinux tree copies one byte too much.
>>> Basically, it misses something like the following klibc patch:
>>> http://git.kernel.org/cgit/libs/klibc/klibc.git/commit/klibc/strlcpy.c?id=4644bd92e21c7fd9a48dd8dfd0c4f8ef772843f0
>>>
>>> As the current klibc may carries lots of other relevant fixes as well, I
>>> wonder whether there is a way to import a newer klibc, or what's the
>>> best way to handle this problem anyway.
>>  
>> Is this some kind of bug report?
> 
> Yes.  The current strlcpy() implementation in Syslinux is broken,
> missing the fix in the above commit.  Likewise strlcat(), and some other
> (mostly string-) functions at least.  Some of the bugs could be fixed by
> incorporating the respective files from the current klibc source, but
> I'm not sure how hpa wishes to manage his parallel code bases, so I
> decided to ask first.
> 

We should go ahead and just do that... it has just been lack of time on
my part.

	-hpa