[syslinux] [PATCH] isohybrid: fix overflow on 32 bit system

[H. Peter Anvin]

On 06/20/2014 05:56 AM, Ady wrote:
> 
>> When call isohybrid with option '-u', it overflows on a 32 bits host. It
>> seeks to 512 bytes before the end of the image to install gpt header. If
>> the size of image is larger than LONG_MAX, it overflows fseek() and
>> cause error:
>>
>> isohybrid: image-x86-64-20140505110100.iso: seek error - 8: Invalid argument
>>
>> Replace fseek with fseeko to fix this issue.
>>
>  
> The Perl variant, isohybrid.in, seems to be getting left behind 
> regarding several patches. I don't recall whether there is at least 
> some mention in the isohybrid docs about the existence of 2 variants 
> included in Syslinux (and that is in addition to other isohybrid 
> methods outside Syslinux). Is there any reference?
> 

I don't know of any missing functionality in the Perl version, but
perhaps I'm wrong.  We can kill it if it is truly behind, but it does
have the advantage of being platform-independent.

The fseeko() fix applies to the C version only; the Perl runtime would
contain this internally.

	-hpa