[syslinux] [PULL 1/8] Move partiter from com32/chain to com32/lib/syslinux
Michal Soltys
soltys at ziu.info
Sat Aug 8 03:49:20 PDT 2015
On 2015-07-23 01:27, Paulo Alcantara via Syslinux wrote:
> From: "Raphael S. Carvalho" <raphael.scarv at gmail.com>
>
> MultiFS depends on the availability of partiter to find a partition.
>
> Cc: Gene Cumm <gene.cumm at gmail.com>
> Signed-off-by: Raphael S. Carvalho <raphael.scarv at gmail.com>
> Signed-off-by: Paulo Alcantara <pcacjr at zytor.com>
> ---
> com32/chain/Makefile | 2 +-
> com32/chain/chain.c | 4 +-
> com32/chain/mangle.c | 4 +-
> com32/chain/mangle.h | 2 +-
> com32/chain/options.c | 4 +-
> com32/chain/partiter.c | 726 --------------------------------------
> com32/chain/partiter.h | 119 -------
> com32/chain/utility.c | 256 --------------
> com32/chain/utility.h | 75 ----
> com32/include/syslinux/partiter.h | 119 +++++++
> com32/include/syslinux/utility.h | 76 ++++
> com32/lib/syslinux/partiter.c | 726 ++++++++++++++++++++++++++++++++++++++
> com32/lib/syslinux/utility.c | 256 ++++++++++++++
For the record, moving utility.h (which is just a bunch of functions
referenced in different chain files) is probably too much. And those
functions are not that useful outside chain.
Essentially, just:
- move warn(), critm(), error() to partiter.h
- redefine guid_is0() in partiter.c
- remove references to utility.h
Would be IMHO cleaner approach.
More information about the Syslinux
mailing list