[syslinux] [PATCH] Updated udp.c to use real client ip and subnetmask values if on local subnet

Gene Cumm gene.cumm at gmail.com
Sat Aug 15 06:50:27 PDT 2015


On Jul 27, 2015 12:30 PM, "Patrick Masotta" <masottaus at yahoo.com> wrote:
>
> >>>
>  > I think these changes would solve the thing.
>  >
>  > ...
>  > -EFI_SERVICE_BINDING *sbp;
>  > +EFI_SERVICE_BINDING *sbp =NULL;
>  > ...
>  >
>  > -    if (status != EFI_SUCCESS)
>  > +    if (status != EFI_SUCCESS || sbp ==
>  NULL)
>  >        goto free_binding;
>  > ...
>
>  The presumption was that we'd see an error rather than
>  non-error from LibLocateHandle() when nr_handles is 0 and be guaranteed
to find a
>  matching handle.  Your additional measures seem the best choice.
>  --
>  -Gene
> <<<
>
> OK I have adopted this code approach; testing it since last
> week, so far so good.
> Presumably there are other people testing this; feedback appreciated.
>
> Best,
> Patrick
>

Jeff Sloan, have you been able to test the latest commit, e466d249 ?

--Gene


More information about the Syslinux mailing list