[syslinux] [PATCH] xfs: Add support for v3 directories

[Ady]

> 
> On Tue, December 15, 2015 5:50 am, Ady via Syslinux wrote:
> >
> >> Besides supporting newer version of xfs file system, this patch also
> >> does some code refactoring and fix completely broken listing and
> >> searching on v2-3 node directories.
> >>
> >
> > Thank you.
> >
> > About the XFS "version" you are mentioning, a small clearer reference
> > might be worth.
> >
> > The initial problem that triggered the need for this patch is seen when
> > formatting the partition with xfsprogs v4.x, not necessarily with prior
> > versions of xfsprogs.
> >
> > Searching information about what changed in xfsprogs v4.x, there are
> > some references to "XFS v.5". At the same time, this patch mentions
> > versions 1/2/3 of XFS node directories. These several not-so-clear
> > "version" references could possibly be a source of confusion, if not
> > now, then for some users asking questions in the future, or for future
> > bug reports.
> >
> > Could someone please clarify?
> 
> 
> I'm not an xfs guru, but what I was trying to refer to is about version of
> the file system metadata. That has nothing to do with xfsprogs versions.
> I've just followed spec and looked at the new fs metadata structures --
> which are mentioned as v3 ones -- to fix the known issues.
> 
> Paulo
> 
 
 
OK. In case it happens to be relevant for future questions / bug 
reports...

XFS on disk format "V5" was officially released with xfsprogs v.3.2, 
and the support for it was included in kernel 3.15.

See "XFS_SB_VERSION_NUM" "V5" in the xfsprogs source code and the 
release announcement for xfsprogs v.3.2.0.

When initially formatting with mkfs.xfs v3.2.x and then installing 
EXTLINUX v.6.03 on it, the resulting boot is successful. But, when 
formatting with mkfs.xfs v4.2.x (or newer) and then installing EXTLINUX 
v.6.03 on it, the resulting boot fails. This was the trigger for this 
new patch.

I do not know whether the issue is/was only the "node directories v3", 
or if the matter is larger than that (perhaps including the 
"XFS_SB_VERSION_NUM" "V5"). The fact that mkfs.xfs v.3.2.x resulted in 
a successful boot in one test does not completely discard the 
possibility that it could had failed too.

Let's hope this patch solves the issue(s) completely.

On a side note, considering that the initial BTRFS support in EXTLINUX 
shared at least some code with the support for XFS, I am wondering 
whether there is a need to also review the BTRFS code in EXTLINUX too. 
Let's not forget that there have been some reports about failing to 
boot in BTRFS after some update. Considering that this patch for XFS is 
also aimed to fix some issues (e.g. "fix completely broken listing and 
searching..."), then reviewing the BTRFS code might also be worth 
(especially with a recent BTRFS version, such as BTRFS 4.3.1, released 
during 2015Nov).

TIA,
Ady.
 
> _______________________________________________
> Syslinux mailing list
> Submissions to Syslinux at zytor.com
> Unsubscribe or set options at:
> http://www.zytor.com/mailman/listinfo/syslinux
>