[syslinux] Use z size specifier for printf-ing size_t variable

Ady ady-sf at hotmail.com
Fri Feb 6 06:38:12 PST 2015


> On Fri, Feb 6, 2015 at 6:55 AM, Martin Str|mberg <ams at ludd.ltu.se> wrote:
> > On Sun, Jan 25, 2015 at 06:13:13PM -0200, Raphael S Carvalho wrote:
> >> On Sat, Nov 22, 2014 at 10:39 AM, Martin Str|mberg <ams at ludd.ltu.se> wrote:
> >> > Hello.
> >> >
> >> > Use the z size specifier to printf-ing size_t variables to get rid of gcc
> >> > warning
> >> > format ‘%08x’ expects type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
> >> Please, add the signed-off line.
> >
> > I'm not sure what you want me to do. Should I resend the patch with a
> > signed-off line?
> Basically yes, and if you want your patch to be applied.
> 
> Follow an explanation on why it's important:
> 
> "12) Sign your work
 
 (snip) 
 
> then you just add a line saying
> 
> Signed-off-by: Random J Developer <random at developer.example.org>"
> 
> Source: /doc/SubmittingPatches
> >
> >
> > --
> > MartinS
> 
> 
> 
> -- 
> Raphael S. Carvalho
> 
 
Generally speaking, adequate patches are helpful and desired, and there 
have been cases in which patches have been rejected or inapplicable 
because of inadequate formatting or lack of some information. But, in 
this particular case, AFAIK the patch in question was already applied 
so I would tend to think that there is no need to resend it.

Additional patches are very welcome :), and if they are "fully 
compliant", even better.

Regards,
Ady.
 
> _______________________________________________
> Syslinux mailing list
> Submissions to Syslinux at zytor.com
> Unsubscribe or set options at:
> http://www.zytor.com/mailman/listinfo/syslinux





More information about the Syslinux mailing list