[syslinux] boot... round 2

poma pomidorabelisima at gmail.com
Thu Jul 2 05:06:49 PDT 2015


On 02.07.2015 11:10, Thomas Schmitt wrote:
> Hi,
> 
> poma wrote:
>> -       if (c <= ' ' || c == '\x7f') {
>> +       if (c <= ' ' && c == '\x7f') {
> 
> As Geert Stappers pointed out (and can be verified by a
> simple test program), the reinstated term
>   (c <= ' ' && c == '\x7f') 
> evaluates always as false, because ('\x7f' <= ' ') is false.
> 
> So it is equivalent to removing the code branch
> 
> 	    if (!was_space)
> 		*dst++ = '_';
> 	    was_space = true;
> 
> 
> I understand the function shall convert whitespace to '_',
> condense groups of neighboring whitespaces to a single '_',
> discard leading and trailing whitespace.
> 
> In its current git state it converts
> 
>   "abc"       ->  "abc"
>   " abc "     ->  "abc"
>   " a  b c "  ->  "a_b_c"
> 
> The change to
>   (c <= " " && c == "\x7f")
> disables this conversion completely.
>   " a  b c " -> " a  b c "
> 
> 
> It seems your use case needs the whitespaces whereas SYSLINUX
> assumes that they are unwanted.
> This collision of need and software model needs to be
> investigated and solved.
> 
> 
> Have a nice day :)
> 
> Thomas
> 


Yeah, I can understand this funky logical "operatourism",
I've already tested it with deletia.

Perhaps syslinux is not the right place to maneuver,
but the challenge for me was to make it less invasive patch,
there.

*If* this is really my user case,
which it really is not - this is the Fedora specificumm,
it would be more like the extlinux config that I use on BIOS machines:

ui menu.c32
menu title The EXTLINUX bootloader
timeout 50

label Rawhide 4.2.0-0.rc0.git4.1.fc23.x86_64
  kernel /vmlinuz-4.2.0-0.rc0.git4.1.fc23.x86_64
  append root=UUID=... ...
  initrd /initramfs-4.2.0-0.rc0.git4.1.fc23.x86_64.img


Thanks, once again.




More information about the Syslinux mailing list