[syslinux] boot... round 2

H. Peter Anvin hpa at zytor.com
Thu Jul 2 15:14:35 PDT 2015


On 07/02/2015 02:12 PM, Thomas Schmitt via Syslinux wrote:
> Hi,
> 
> hpa wrote:
>> On PowerPC (I think) "unsigned char" is the default.
> 
> In any case it seems a good idea to interpret the character
> more explicitely. To my experience, one signdness change causes
> a little tree of consequential signedness changes or questionable
> cast operations.
> How about the following instead ?
> 
>   if ((c >= 0 && c <= ' ') || c == '\x7f') {
> 

First of all, this should be an inline instead of being open-coded.  I
thought we had a myisspace() routine already...

	-hpa



More information about the Syslinux mailing list