[syslinux] [PATCH] Updated udp.c to use real client ip and subnetmask values if on local subnet

Patrick Masotta masottaus at yahoo.com
Mon Jul 20 14:28:04 PDT 2015


>>>
 
 Jeff,
 Patrick: Could you try my code from my github repo branch
 efi-multinic?  It's derived from
 Patrick's code and I finally see good
 responses with a VMware VM's e1000e NIC
 (never saw ANYTHING good from
 it until
 now).
 
 git://github.com/geneC/syslinux.git
 https://github.com/geneC/syslinux.git
 
 -- 
 -Gene
 <<<<

I've seen your code.
Your first patch considered Pxebc, UDPv4Sb and  TCPv4Sb are created under the same 
handle but now we know this is not the case.
Your new patch now considers UDPv4Sb and TCPv4Sb are created under the same 
handle thing that we really do not know if is always true or not. 

My patch looks slower than yours because it parses the handles on every attempt of binding 
but it does not make any assumptions about the handles owning SB protocols. I consider this 
approach much safer.
About the speed of my patch; I do not think that matters compared to the time of the smallest 
transfer associated to the created child...
If you are really bothered by parsing the handles every time then we should save both;
the associated UDPv4Sb and TCPv4Sb handles considering they might be different.

Best,
Patrick




More information about the Syslinux mailing list