[syslinux] [syslinux:master] core/pxe: extend parse_dhcp() for packet type

H. Peter Anvin hpa at zytor.com
Mon Jun 22 01:18:14 PDT 2015


On 06/21/2015 11:12 AM, syslinux-bot for Gene Cumm wrote:
> Commit-ID:  38e861ebf45a804bc5fbd74d9c19292822c84487
> Gitweb:     http://www.syslinux.org/commit/38e861ebf45a804bc5fbd74d9c19292822c84487
> Author:     Gene Cumm <gene.cumm at gmail.com>
> AuthorDate: Sat, 20 Jun 2015 21:17:18 -0400
> Committer:  Gene Cumm <gene.cumm at gmail.com>
> CommitDate: Sat, 20 Jun 2015 21:17:18 -0400
> 
> core/pxe: extend parse_dhcp() for packet type
> 
> Add packet type so we can eventually only grab certain data elements from
> the DHCP packets appropriately
> 
> Signed-off-by: Gene Cumm <gene.cumm at gmail.com>

>   *
> + * pkt_type 1 for Discover, 2 for Ack, 3 for ProxyDHCP, 0 for everything
> + *

What does 0 even mean here?  It makes the code more complicated, and it
is never used, and it is not at all clear to me that it is even meaningful.

	-hpa



More information about the Syslinux mailing list