[syslinux] [PATCH 0/1] EFI PXE DHCP/proxyDHCP issues fix

[Patrick Masotta]

 >>>
 > DhcpDiscover.Dhcpv4 gets populated at the "Dhcp4SendDiscover" event
 
 Syslinux on EFI won't be
 sending these packets.  The underlying EFI
 framework will.
 <<<

Sure but the idea is to parse the packets that have the info sent by the DHCP Server...


>>> 
 DhcpAck and DhcpOffer
 shouldn't contain the details.  DhcpDiscover and
 DhcpRequest should.
<<<

Why do you think so?
The client IP, the TFTP server IP, etc are contained 
on DHCP Server sent packets.
 
>>>
 In the current code,
 there's three calls to parse_dhcp().
 
 1) With DhcpDiscover.  This is intended to get
 the client identifiers
 that the servers
 never bother returning like DHCP option 60 (Vendor
 Class
 Identifier).

 2) With DhcpAck.  This
 is intended to get the server-provided
 parameters for basic network interactions like
 IPv4 address, subnet
 mask, gateway and
 DNS.
 3) With PxeReply.  The intention here
 was to grab the advanced
 server-provided
 parameters for network booting like the file and
 server to grab it from.
 
 The code of #3 is currently wrong as it ignores
 ProxyOffer.  I'm not
 arguing this needs
 to be patched.
 
 Your patch
 ignores the client identifiers (call #1).
 <<<

I'm running my patch every day and "so far" it works very well.
I do not recall now the need to parse option 60 on the client packet,
it should only contain "PXEClient" right?

Best,
Patrick