[syslinux] Remove trailing spaces

Gene Cumm gene.cumm at gmail.com
Wed Oct 14 02:31:44 PDT 2015


On Tue, Oct 13, 2015 at 10:10 PM, Ady via Syslinux <syslinux at zytor.com> wrote:
>
>> Looking around, there appear to be a lot of small places needing some
>> whitespace cleanup/reconciliation.
>>
>
> Just to be clear, I am not criticizing, but actually asking...
>
> Are those white-space characters impacting the binaries being built?

No, unless a compiler has a bug.

> Would they affect common users?

Same.

> Are those characters affecting developers? For instance, do they affect
> some git command? Or, do they make the code more difficult to read /
> follow / analyze / debug / patch?

It's mostly about inconsistent style.  The biggest impact is in
leading to long lines.

> If a commit correcting these white-space characters were to be merged,
> would you consider also merging commits correcting typos that do not
> affect the code itself (e.g. "auxilliary" to "auxiliary"; "AFP" to
> "APM" in isohybrid-related code...)? Perhaps all these corrections
> could be made in one "correct typos" commit?

HPA ran Nindent en masse at one point but explicitly separated it to
one commit per file to help bisection.

-- 
-Gene


More information about the Syslinux mailing list