[syslinux] Remove trailing spaces

Erwan Velu erwanaliasr1 at gmail.com
Wed Oct 14 05:03:32 PDT 2015


Whitespaces are an issue in git as they are considered as a valid char. As
a result, you can create conflicts between patches just because of a
whitespace.
It's a good pratice avoiding them to avoid useless conflicts.

After that, agreed that's just a style issue which could be enforced on the
server side if we want by having hooks checking the style.

In my daily work, I'm used to chase style issues & whitespace to get a
decent visual.

My 2 cents,

2015-10-14 4:10 GMT+02:00 Ady via Syslinux <syslinux at zytor.com>:

>
> > Looking around, there appear to be a lot of small places needing some
> > whitespace cleanup/reconciliation.
> >
>
> Just to be clear, I am not criticizing, but actually asking...
>
> Are those white-space characters impacting the binaries being built?
>
> Would they affect common users?
>
> Are those characters affecting developers? For instance, do they affect
> some git command? Or, do they make the code more difficult to read /
> follow / analyze / debug / patch?
>
> If a commit correcting these white-space characters were to be merged,
> would you consider also merging commits correcting typos that do not
> affect the code itself (e.g. "auxilliary" to "auxiliary"; "AFP" to
> "APM" in isohybrid-related code...)? Perhaps all these corrections
> could be made in one "correct typos" commit?
>
> > I already merged it as an edited merge with addendum to note such.
>
> Thank you.
>
> >
> > --
> > -Gene
> > _______________________________________________
> > Syslinux mailing list
> > Submissions to Syslinux at zytor.com
> > Unsubscribe or set options at:
> > http://www.zytor.com/mailman/listinfo/syslinux
> >
>
>
> _______________________________________________
> Syslinux mailing list
> Submissions to Syslinux at zytor.com
> Unsubscribe or set options at:
> http://www.zytor.com/mailman/listinfo/syslinux
>


More information about the Syslinux mailing list