[syslinux] [PATCH 2/4] Remove unused linker scripts

[Gene Cumm]

On Thu, Oct 15, 2015 at 3:49 PM, Celelibi <celelibi at gmail.com> wrote:
>> As the commit line say, it removes unused linker scripts. This commit
>> intended to be really dumb: unused = delete. And mbr/mbr.ld isn't
>> used. I think it's detter delete this one and then move
>> mbr/i386/mbr.ld to mbr/mbr.ld in a second commit. Which I didn't do
>> because I wasn't sure of that.
>>
>> I didn't delete mbr/x86_64/mbr.ld because I wasn't sure it wouldn't be
>> used. It will be removed in the next version of this patch series (see
>> below).
>
> *morning english is broken english*
> I'll rephrase this:
> As the commit line say, it removes unused linker scripts. This commit
> intended to be really dumb: unused = delete. And since I wasn't sure
> mbr/x86_64/mbr.ld was actually used, I left it. I'll remove it and
> move mbr/i386/mbr.ld to mbr/mbr.ld in a second version of this patch
> series.

I'd like to try seeing if I can re-merge some of those old commits
with your changes and see if the "forgotten" changes still work.

> Anyway, I think it's better to separate the dumb commit that remove
> the unused scripts from the more "risky" ones that may actually have
> an effect. Should it be to simplify bisection.

Agreed.

> If I may, I'd make a parallel with whitespaces commits. There are two
> ways of thinking:
> - either you only fix the whitespaces around the lines you actually change ;
> - or you fix the whitespaces of a whole file and make the changes a
> separate commit.
>
> Since I had several other files to delete, I choosed the latter way.

-- 
-Gene