[syslinux] [PATCH 2/4] Remove unused linker scripts

[Celelibi]

2015-10-16 11:42 UTC+02:00, Gene Cumm <gene.cumm at gmail.com>:
> On Thu, Oct 15, 2015 at 3:34 PM, Celelibi <celelibi at gmail.com> wrote:
>
>> Yeah, I'm preparing a port of all the commits that affected
>> core/syslinux.ld that were not in core/i386/syslinux.ld. If you want
>> to take a look at it, a WIP version of this is on my github
>> branch wip/cleanup-linkerscripts.
>> https://github.com/Celelibi/syslinux/tree/wip/cleanup-linkerscripts
>>
>> (Still need a bit of work and testing.)
>>
>> Celelibi
>
>
>
> On Thu, Oct 15, 2015 at 6:50 PM, Gene Cumm <gene.cumm at gmail.com> wrote:
>
>> I'd like to try seeing if I can re-merge some of those old commits
>> with your changes and see if the "forgotten" changes still work.
>
> https://github.com/geneC/syslinux/tree/linker
>
> Keep the history as it was and remove files that should have never existed.
>
> --
> -Gene
>

As I said on IRC, I have a remark about the patches in your linker
branch: putting core/syslinux.ld to use in a single commit would make
a drastic change in the content of the used linker script. That may
not be easy to bisect in case of bug if, for instance, some of the
current code has an incompatibility with the patches that were
previously hidden.

So I'd propose to take from the current stat of the used linker
scripts and port the lost patches one by one. Without forgetting to
extend those patches to the EFI linker scripts.

https://github.com/Celelibi/syslinux/tree/cleanup-linkerscripts-2

I made the HIDDEN symbols the last patches in order to be easily
ignored if you want to keep the compatibility with older linkers.

I tested every commit of this branch on qemu and hardware for the BIOS
version. I tried testing for UEFI but it turns out HDT contains some
BIOS-only code (which was my main test).


Celelibi