[syslinux] ldlinux: Fix return pointer to local data

[Geert Stappers]

On Sun, Oct 18, 2015 at 10:18:04AM -0700, syslinux-bot for Sylvain Gault wrote:
> Commit-ID:  8dc6d758b564a1ccc44c3ae11f265d43628219ce
> Gitweb:     http://www.syslinux.org/commit/8dc6d758b564a1ccc44c3ae11f265d43628219ce
> Author:     Sylvain Gault <sylvain.gault op gmail.com>
> AuthorDate: Tue, 13 Oct 2015 06:18:07 +0200
> Committer:  Paulo Alcantara <pcacjr op zytor.com>

Nice!

It is good the see the Syslinux project has an extra committer.


> CommitDate: Sun, 18 Oct 2015 12:56:32 -0300
> 
> ldlinux: Fix return pointer to local data
> 
> The command-line parsing used to return a pointer to a local array. The
> code used to work by chance, but now, gcc 5 is able to detect it and
> return a NULL pointer instead.
> 
> The buffer is now marked static. This shouldn't be a problem as only one
> command line can be read at a time.
> 
> Signed-off-by: Sylvain Gault <sylvain.gault op gmail.com>
> Tested-by: poma <pomidorabelisima at gmail.com>
> Signed-off-by: Paulo Alcantara <pcacjr op zytor.com>
> 
> ---
>  com32/elflink/ldlinux/cli.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/com32/elflink/ldlinux/cli.c b/com32/elflink/ldlinux/cli.c
> index 6ff30c6..3119b11 100644
> --- a/com32/elflink/ldlinux/cli.c
> +++ b/com32/elflink/ldlinux/cli.c
> @@ -125,7 +125,7 @@ const char *edit_cmdline(const char *input, int top /*, int width */ ,
>  			 int (*pDraw_Menu) (int, int, int),
>  			 void (*show_fkey) (int), bool *timedout)
>  {
> -    char cmdline[MAX_CMDLINE_LEN] = { };
> +    static char cmdline[MAX_CMDLINE_LEN] = { };
>      int key, len, prev_len, cursor;
>      int redraw = 0;
>      int x, y;

@huddy: check your setup (with the very long command line)
with the above patch applied


Groeten
Geert Stappers
-- 
Leven en laten leven
------------- volgend deel ------------
Een niet-tekst bijlage is gescrubt...
Naam: signature.asc
Type: application/pgp-signature
Grootte: 836 bytes
Omschrijving: Digital signature
URL : <http://www.zytor.com/pipermail/syslinux/attachments/20151019/fe4ca35d/attachment.sig>