[syslinux] [PATCH 0/3] efi: A few warning fixes

Gene Cumm gene.cumm at gmail.com
Thu Sep 10 03:08:58 PDT 2015


On Tue, Aug 25, 2015 at 10:28 PM, celelibi--- via Syslinux
<syslinux at zytor.com> wrote:
> From: Sylvain Gault <sylvain.gault at gmail.com>
>
> I don't know if I should merge those trivial warning fix into one commit. I
> can reformat it as requested. Those are a few warning fixes for the efi part.
> The code involved has mainly been introduced in recent commits.
>
> Sylvain Gault (3):
>   efi: fix warnings about argument types
>   efi: fix pointer-type mismatch assigment warning
>   efi: fix warning about unused variable
>
>  efi/main.c | 6 +++---
>  efi/pxe.c  | 1 -
>  2 files changed, 3 insertions(+), 4 deletions(-)

In my opinion, if there's a question about splitting commits and you
can build at each stage, it's probably worth splitting.  Micro-commits
help if there's a need for bisection, especially if you're touching
different code blocks each time.  It means fewer lines of code to
examine after the bisection is complete.

That said, these are so small it's almost trivial to examine,
especially when only 1 file is changed per commit so they could have
been combined but I'm fine either way.

These have been merged.

-- 
-Gene


More information about the Syslinux mailing list