[syslinux] [PATCH 0/4] efi: Makefile improvement

Patrick Masotta masottaus at yahoo.com
Wed Sep 16 09:25:49 PDT 2015


>>>
 > How about
 > 1) Laying every needed versions of gnu-efi under its own directory where
 > its name could be just the version.
 > 2) Defining the gnu-efi version to use in a Makefile variable; if the source
 > is not present then the Makefile triggers the corresponding
 > "check out" with git.
 
 > The original tarball will contain (not check out needed )the source of the
 > gnu-efi version used for the
 > corresponding build. But just changing a Makefile variable we would be able
 > to build against the different
 > gnu-efi versions with 0 hassle.
 >
 > What do you guys think? Could this be done?
 
 Not sure I like the idea of accumulating the versions of gnu-efi.
 That'd make one submodule per version that has been used at 
some point in history.
 And when you work on it and want to just test several of versions of
 gnu-efi (that are not yet registered as submodule), that'd be annoying
 to have to patch the makefile and add a new submodule everytime.
 The submodule repository would have to be cloned from the network, which
 can be long.
 
 For the problem of the tarball sources, we could only perform the "git
 submodule update --init" if this is a git repository.
 
 Celelibi
 <<<

1) Gnu-efi sources are about 139 KB then I do not think it would be much of a problem
having more than one submodule version under the Syslinux building tree. Also the non-used
versions could be easily removed when invoking "#make spotless".

2) Cloning from the net shouldn't be that bad considering the involved sizes, plus it is done 
only once for every version.

3) Testing versions not registered as submodule yet could be easily done
w/o touching the makefiles just by i.e. overwriting the content of the last version submodule 
directory with the sources being tested.

4) I think this approach makes very easy testing different gnu-efi versions; today doing this
is a real PITA.

Just my 2 cents.

Best,
Patrick


More information about the Syslinux mailing list