[syslinux] [PATCH 1/4] efi: Don't unnecessarily rebuild syslinux.so

Gene Cumm gene.cumm at gmail.com
Wed Sep 16 15:45:50 PDT 2015


On Wed, Sep 16, 2015 at 12:03 PM, Paulo Alcantara via Syslinux
<syslinux at zytor.com> wrote:
> On Mon, 14 Sep 2015 05:50:56 +0200
> celelibi--- via Syslinux <syslinux at zytor.com> wrote:
>
>> From: Sylvain Gault <sylvain.gault at gmail.com>
>>
>> OBJ directory creation changed from a .PHONY target to a real target
>> used through an order-only dependency.
>>
>> A target depending on another target marked .PHONY is always rebuilt,
>> thus forcing all the .o files to be rebuilt everytime.
>>
>> Signed-off-by: Sylvain Gault <sylvain.gault at gmail.com>
>
> Reviewed-by: Paulo Alcantara <pcacjr at zytor.com>
>
> Thanks,
>
> Paulo

Tested, merged and pushed.  Thanks for the catch.

-- 
-Gene

>> ---
>>  efi/Makefile | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/efi/Makefile b/efi/Makefile
>> index d5443bd..bbf23f2 100644
>> --- a/efi/Makefile
>> +++ b/efi/Makefile
>> @@ -60,11 +60,10 @@ DATE    := $(shell sh $(SRC)/../gen-id.sh
>> $(VERSION) $(HEXDATE)) endif
>>  CFLAGS               += -DDATE_STR='"$(DATE)"'
>>
>> -.PHONY: subdirs
>> -subdirs:
>> -     mkdir -p $(ARCH)
>> +$(OBJ)/$(ARCH):
>> +     mkdir -p $@
>>
>> -$(OBJS): subdirs
>> +$(OBJS): | $(OBJ)/$(ARCH)
>>
>>  # The targets to build in this directory
>>  BTARGET  = syslinux.efi


More information about the Syslinux mailing list