[syslinux] RFC: [Patch] libpuload: use previous TFTP OK status definition

Gene Cumm gene.cumm at gmail.com
Sat Apr 23 05:35:31 PDT 2016


libupload: Use previous TFTP OK status definition

FTBFS: com32/hdt/hdt-dump.c:227:39: error: ‘TFTP_OK’ undeclared
  (first use in this function)

Signed-off-by: Gene Cumm <gene.cumm at gmail.com>

Should we trim "ERR_" off the definition or change all of the places
this macro is used?  Trimming means we have two possible spots with
incongruent definitions (bit order difference).  I'm leaning towards
changing where it's used.


diff --git a/com32/libupload/tftp.h b/com32/libupload/tftp.h
index 209d975..27f5fbe 100644
--- a/com32/libupload/tftp.h
+++ b/com32/libupload/tftp.h
@@ -18,7 +18,7 @@ TFTP_ERR_BAD_OPTS = 8, /**< Option negotiation failed */
 /* The following are not defined in RFC, for internal usage only */
 TFTP_ERR_UNABLE_TO_RESOLVE = 9,
 TFTP_ERR_UNABLE_TO_CONNECT = 10,
-TFTP_ERR_OK = 11,
+TFTP_OK = 11,
 TFTP_ERR_NO_NETWORK = 12,
 };



More information about the Syslinux mailing list