[syslinux] [PATCH 2/5] ntfs: remove unused variable and have ntfssect use char API calls

Shao Miller sha0.miller at gmail.com
Wed Feb 24 15:43:22 PST 2016


On 2/24/2016 08:02, Pete Batard via Syslinux wrote:
> The variable 'ok' is never used and generates a warning. Remove it. Also
> ntfssect.c is designed to be compiled in non Unicode mode when using
> MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use
> of 'A' API calls) so that it doesn't break when compiled in Unicode
> mode, which is what Rufus uses with MSVC.
>

Did you happen to notice anything unusual when compiling with MinGW 
under Linux, once 'ok' was removed?  I seem to recall warnings about 
unused results, but not of unused objects.  Maybe that's an incorrect 
recollection or maybe it's ancient history, however.

- Shao Miller
Synthetel : https://www.synthetel.com


More information about the Syslinux mailing list