[syslinux] [PATCH 0/1] UEFI UDP/TFTP

[Geert Stappers]

On Mon, Feb 29, 2016 at 08:41:51AM +0000, Patrick Masotta via Syslinux wrote:
> > Such coding style change
> > did me really stop removing this unified patch.
> 
> @Gert; 
> 
> I'm sorry, but I honestly do not understand your English or rationality.
> What does ""...did me really stop removing this unified patch"" mean??? (rhetoric question; please do not answer)

The sorry is on me, 'removing' should have been 'reviewing'

Now in context:
|
|> -void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t ip,
|> -                   uint16_t port)
|> +void core_udp_connect(struct pxe_pvt_inode *socket, uint32_t src_ip,
|> +                   uint16_t src_port)
|
|Changed 'ip' and 'port' in 'src_ip' and 'src_port'.
|
|However: 'src_ip' and 'src_port' are not in
|} + * @param:ip,                the source ip address
|} + * @param:port,      the source port number, host-byte order
|
|
|  <snip/>
|
|> -static EFIAPI void udp4_cb(EFI_EVENT event, void *context)
|> +VOID
|> +EFIAPI
|> +UdpIoOnDgramSent (
|> +  IN EFI_EVENT       event,
|> +  IN VOID*           context
|> +  )
|
|Such coding style change
|did me really stop reviewing this unified patch.
|


> BTW did you try the new code?? I know, it takes some knowledge and probably
> it is not as easy as finding "misplaced spaces" and the like but it is fun; give it a try...
> 
> 
> @Rest of the list;
> 
> Sorry guys about the format; I did not use the "Linux kernel coding style".
> 
> 
> Best,
> Patrick


Regards
Geert Stappers
Who looks forward for good patches,
at least looks forward on _feedback_ on patches.
-- 
Leven en laten leven