[syslinux] [PATCH] : Adding dlabel option to chain.c32

[poma]

On 16.07.2016 19:55, poma wrote:
> On 16.07.2016 10:39, Erwan Velu wrote:
>> The idea is to boot a disk in an mbr fashion while using the GPT (not
>> filesystem) label to detect the disk.
>>
>> That is useful when you use grub2 & gpt. I was in case where my nodes
>> (100s) have 8 disks each and no guarantee of which disk is "bootable" in
>> the disk.
>>
>> This way I can tell "please boot the disk that have one partition labelled
>> "xyz"".
>>
>> So nothing related to filesystem but gpt labels & disks.
>>
> 
> OK, this is sucus of your patch:
> https://github.com/ErwanAliasr1/syslinux/commit/ebf8cbf#diff-6fb847366ce3f1ddbf6ffd8fd4d408fcR165
> +		    // We don't care about the actual partition that matched
> +		    pi_del(&iter);
> 
> i.e.
> https://github.com/ErwanAliasr1/syslinux/commit/ebf8cbf#diff-6fb847366ce3f1ddbf6ffd8fd4d408fcR167
> +		    // Let's return the disk itself instead
> +		    iter = pi_begin(&diskinfo, opt.piflags);
> +		    goto ok;
> 
> 
> Still, there is no GPT label, but *GPT* *Partition* *name* ;)
> https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_entries
> 


probably whence the "inconsistency" began - with so-called GPT partition "label":

chain: Support booting GPT partition by label
http://git.zytor.com/syslinux/syslinux.git/commit/?id=bf4d560


GPT partition "label" can be synonymous, but actual option should be the *name*, as specified in GPT scheme.