[syslinux] [PATCH] Fix recognition of keeppxe option

[Gene Cumm]

On Fri, Jun 10, 2016 at 2:06 AM, Adam Goldman via Syslinux
<syslinux at zytor.com> wrote:
> PXELINUX has stopped recognizing the keeppxe option on the kernel
> command line. Here is a patch to make it work again.
>
> With COM32, it is no longer possible to use preprocessor directives to

Not COM32 but ldlinux.c32 as a result of splitting the core binary in
two with variant-specific code to load another file of common code.

> determine the SYSLINUX variant. The code inside the #if will never be
> compiled. So, I changed it to use syslinux_filesystem() to determine the
> variant. Also, I moved the relevant code from

Probably the best choice.

> kernel.c:new_linux_kernel() to load_linux.c:bios_boot_linux() because
> there is no convenient way in new_linux_kernel() to control the boot
> flags value.

This is the part that has me questioning things and trying to recall
if any other KERNEL-like directives ever utilize keeppxe.


> In basic testing, keeppxe seems to work with the patch applied.

Considering that it's used only within ldlinux.c32, I'd probably
consider moving it to ensure we always have the variable.

-- 
-Gene