[syslinux] [PATCH] Fix for crash with certain EFIs

Ady Ady ady-sf at hotmail.com
Thu Oct 20 07:46:34 PDT 2016


> Thank you all.
> 
> It looks like -mno-red-zone flag is already in master branch since
> commit 7d70885d, but it seems it is applied to all EFI builds.
 

Finally we are on the same page.


> 
> IIUC, the problem only affects efi64 builds.
 

Have you actually tested efi32 (ia32) builds?


> 
> So here's the modification of my patch to only apply -mno-red-zone
> flag to efi64 target. The patch is against master. I verified that it
> builds correctly in master. Please feel free to accept or reject this
> solution.
> 
> Best Regards,
> - Chris
 
I still have some problem understanding this situation (FWIW).

If the -mno-red-zone flag was already applied for all EFI builds (in 
the current git master head and in 6.04-pre1), then what exactly makes 
the current 6.04-pre1 *pre-built* binaries fail for you? As Jur van der 
Burg reported, 6.04-pre1 works just as well as your previously-proposed 
patch; so, what exactly are we changing now that is not already 
achieved in the current code? I am failing to grasp what exactly was 
making it fail for you.

I apologize if these questions are trivial to others; to me they are 
not.

Anyway, I appreciate contributions and I hope to see more active and 
effective Syslinux development.

Regards,
Ady.



More information about the Syslinux mailing list