[syslinux] [PATCH 3/4] Removing the udp_reader efi_binding

Julien Viard de Galbert jviarddegalbert at online.net
Wed Jul 26 01:08:15 PDT 2017


Hello,

Any new on integrating this patch ?

Do you need more testing, or do you want me to rewrite it differently.

Best Regards

Julien VdG

----- Mail original -----
De: "Gene Cumm" <gene.cumm at gmail.com>
À: "Matt Fleming" <matt at codeblueprint.co.uk>
Cc: "Julien Viard de Galbert" <jviarddegalbert at online.net>, "For discussion of Syslinux and tftp-hpa" <syslinux at zytor.com>
Envoyé: Mercredi 31 Mai 2017 22:54:19
Objet: Re: [syslinux] [PATCH 3/4] Removing the udp_reader efi_binding

On Wed, May 31, 2017 at 10:06 AM, Matt Fleming <matt at codeblueprint.co.uk> wrote:
> On Wed, 31 May, at 07:45:00AM, Gene Cumm wrote:
>> >  extern EFI_GUID Udp4ServiceBindingProtocol, Udp4Protocol;
>> >
>> > -/*
>> > - * This UDP binding is configured to operate in promiscuous mode. It is
>> > - * only used for reading packets. It has no associated state unlike
>> > - * socket->net.efi.binding, which has a remote IP address and port
>> > - * number.
>> > - */
>>
>> This part has me puzzled why Matt was creating a promiscuous binding
>> instead of re-using the existing binding.
>
> Sorry, I'm afraid I don't remember what I was thinking when I wrote
> that, so I definitely have no problem with it being ripped out.

Gotta love git.  git blame has me thinking it's leftovers from
fe283b78c that weren't cleaned up in c5c37402

It sure looks like it's needed.

-- 
-Gene



More information about the Syslinux mailing list