[syslinux] [PATCH] Fix recognition of keeppxe option

Gene Cumm gene.cumm at gmail.com
Sat Mar 18 18:50:40 PDT 2017


On Sat, Mar 18, 2017 at 7:15 PM, Ady Ady via Syslinux
<syslinux at zytor.com> wrote:
>
>> Pushed.  Thank you for digging so deeply on this.
>>
>
> Gene,
>
> For the c32 modules to be able to use the keeppxe option, and
> considering that the issue in v.5.+ is that 'IS_PXELINUX' is/was dead
> code, is there any chance that the code in:
> com32/modules/whichsys.c
> would help?

The new code uses syslinux_filesystem() while whichsys.c uses
syslinux_derivative_info().filesystem

com32/include/syslinux/config.h:186:

static inline enum syslinux_filesystem syslinux_filesystem(void)
{
    return syslinux_derivative_info()->c.filesystem;
}


> I mean, as a different way of detecting the Syslinux variant.
>
> In fact, the original idea of having the code in whichsys.c librarized
> is probably still relevant.

How do you librarize that?  boot_by_fs(char **sysargs, char **isoargs,
char **pxeargs) ?

-- 
-Gene


More information about the Syslinux mailing list