[syslinux] efi config hang

[Joakim Tjernlund]

On Mon, 2018-12-17 at 23:52 +0100, Lukas Schwaighofer wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> Hi Joakim,
> 
> On Wed, 12 Dec 2018 23:25:24 +0000
> Joakim Tjernlund via Syslinux <syslinux at zytor.com> wrote:
> 
> > I cannot tell but I guess you are using newer gnu-efi. You should
> > check how your repo does this:
> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjoakim-tjernlund%2Fsyslinux%2Fcommit%2F22d32c15ea96c01c8c05b8c1551095716d42f3a4&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7C9725124082b543278fc208d664725495%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C1%7C636806839586869257&sdata=WVzVxf1mhnSeHkm0BEARy7e3W8kmPpB6a%2Bf7eSCG8rg%3D&reserved=0
> 
> This is the corresponding patch used in Debian:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsalsa.debian.org%2Fimages-team%2Fsyslinux%2Fblob%2Fdebian%2Fmaster%2Fdebian%2Fpatches%2F0005-gnu-efi-version-compatibility.patch&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7C9725124082b543278fc208d664725495%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C1%7C636806839586869257&sdata=XaFXPhErsWEfypy9vmpoEGI2chUq3GFGIW4z2ql0ywQ%3D&reserved=0
> 
> The package automatically builds against the gnu-efi version that's
> available in Debian at build time.  At the moment that's 3.0.9 and the
> version Carl uses is linked against that.

I suspect this part is wrong:
-static jmp_buf load_error_buf;
+static jmp_buf *load_error_buf;

That will just define a ptr and using that directly in longjmp/setjmp is odd.

Modifying longjmp/setjmp to.

-longjmp(load_error_buf,1);
+longjmp(&load_error_buf,1);

makes much more sense to me.

 Jocke