[syslinux] Thank you and patch line length

H. Peter Anvin hpa at zytor.com
Sat Feb 28 10:54:43 PST 2009


Gene Cumm wrote:
> Peter, looking back at recent commits, I noticed that you updated
> doc/comboot.txt to reflect that the new COMBOOT calls for directories
> are officially to be included into version 3.74.  Thank you and I hope
> that this functionality provides benefit for others.
> 
> I also noticed that a part of that commit was to rework the line
> length.  What is your preferred line length within the documentation
> and within the code?  I'm ready to submit a patch for my revised
> version of my read-only shell but would rather modify my tree to fit
> your preferred line lengths first then submit the patch.

For plaintext, typically the line break should be around 72 characters,
with 79 as the absolute maximum.  It's not an exact science for me; what
tends to happen is that I edit in emacs and then find myself with an
overlong line, and I just hit emacs "reformat paragraph" command.

For code, do follow SubmittingPatches and keep the line length to < 80.
 As far as indentation level, I'm not as picky as Linus; I've used both
4 and 8 spaces myself, and in some cases even just 2; I've considered
doing a tree-wide reformat to either 4 or 8 spaces but haven't bothered.

However, please try to be consistent within a file.

> Just an FYI: rosh now acts a lot more like ls (except currently
> unsorted) with a few other smoothing finishes.  I wouldn't call it
> complete yet but just more usable.

Cool!

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.




More information about the Syslinux mailing list