[syslinux] bzimage: Merge memory types

[Maarten Lankhorst]

On 08/11/2011 12:11 AM, Matt Fleming wrote:
> On Tue, 2011-08-09 at 01:44 +0200, Maarten Lankhorst wrote:
>> Fix failure to boot because of >128 e820 entries
>>
>> Signed-off-by: Maarten Lankhorst <m.b.lankhorst at gmail.com>
> Applied, thanks.
>
> This is great, you keep sending me patches for things on my TODO
> list ;-) With this patch applied does your machine now boot?
>
> Note that efilinux is still missing support for > 128 e820 entries after
> merging adjacent ones. Support for this requires filling out a struct
> setup_data linked-list and pointing to it from hdr.setup_data. Would you
> be able to test a patch for this (obviously you'll need to revert your
> bzimage patch I just applied while you're testing).
Yeah, most of the chunks get merged, I have like 12 entries left afterwards,
probably even less with unusable/reserved changes below. I'll test a patch for
>128 entries if you send one. With this it boots now by the way.

I don't really know if a patch for >128 will be needed.
As pointed out by someone else on the lkml thread, can you remove
the locate_protocol call in protocol.h, since it seems to be unused,
and breaks compile?
>> Unrelated, I'm pretty sure that that print statement of 'invalid
>> efi memory descriptor type' wont work because of the ExitBootServices
>> On my system adding a similar print statement for warning of merger
>> caused it to reboot.
> Yeah, that does indeed look wrong. It's not OK to call Print() after
> ExitBootServices() because Print() can allocate memory. I'll fix that.
Returning after getting back control is wrong too, or maybe that triple fault was intentional? ;)
>> Also can EfiRuntimeServicesCode be changed from unusable to reserved?
>> and perhaps EfiUnusableMemory to unusable. ;)
> Heh, whoops. I'll make the change, thanks.
>