[syslinux] [PATCH] core/diskboot.inc: fix handover info sanity checks

[H. Peter Anvin]

On 02/21/2011 01:33 PM, Michal Soltys wrote:
> 
> I know I'm nitpicking, but... consider comparison of 16 byte long area
> at address 7BEh ([7BEh .. 7CDh]), against 7C0h . It will not fail the
> check using paragraphs, as 7Bh < 7Ch. But it should as it's overlapping.
> 
> Besides PartInfo is only 8-byte aligned currently (STACK_TOP-44-92), and
> we have (should ?) check for all 76 bytes copied, not only 16 (it looks
> like the check is from pre-GPT-handover times).
> 
> Using normal addresses make the checks pretty straightforward and
> correct, imho (if I didn't miss anything as in v2 patch).
> 

What is the size impact?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.