[syslinux] [PATCH][GIT-PULL] lwIP undiif: Fixes for VMware platforms and general fixes

[Gene Cumm]

On Fri, Oct 14, 2011 at 17:21, H. Peter Anvin <hpa at zytor.com> wrote:
> On 10/13/2011 07:29 PM, Gene Cumm wrote:
>>
>> The following changes since commit
>> 5b08704e284545c82b4c5d3ff3aaee815107f6ef:
>>   H. Peter Anvin (1):
>>         thread: allow marking invalid; allow for static mboxes
>>
>> are available in the git repository at:
>>
>>   git://github.com/geneC1/syslinux.git lwip-undiif-fix-for-hpa
>>
>> Gene Cumm (4):
>>       lwip: undiif: Fix #error typo
>>       lwip: undiif: Fix debug option addressing in update_arp_entry()
>>       lwip:undiif: Use tcpip_input() rather than
>> ethernet_input()/ip_input()
>>       lwip:undiif: Add interface with tcpip_input() callback
>>
>>  core/lwip/src/netif/undiif.c |   12 ++++++------
>>  1 files changed, 6 insertions(+), 6 deletions(-)
>>
>
> Hi Gene,
>
> I have merged this... I'm still not convinced it is the right solution -- in
> particular I'm not convinced we should *ever* call ethernet_input() -- but
> it's a lot better than the previous (known broken) code.
>
> Thanks!

Thanks also to Simon Goldschmidt who saw the issue and suggested the
direction of the fix.

It seems the more important question is what could go wrong.  What if
it's non-Ethernet and calls ethernet_input() or is Ethernet and
doesn't call ethernet_input() but just ip_input() instead?

-- 
-Gene