[syslinux] [PATCH][GIT-PULL] lwIP undiif: Fixes for VMware platforms and general fixes

[H. Peter Anvin]

On 10/14/2011 06:23 PM, Gene Cumm wrote:
>>
>> Hi Gene,
>>
>> I have merged this... I'm still not convinced it is the right solution -- in
>> particular I'm not convinced we should *ever* call ethernet_input() -- but
>> it's a lot better than the previous (known broken) code.
>>
>> Thanks!
> 
> Thanks also to Simon Goldschmidt who saw the issue and suggested the
> direction of the fix.
> 
> It seems the more important question is what could go wrong.  What if
> it's non-Ethernet and calls ethernet_input() or is Ethernet and
> doesn't call ethernet_input() but just ip_input() instead?
> 

The difference, as far as I can tell, is that ethernet_input() expects a
14-byte Ethernet header, and will handle ARP.  Since the UNDI code
should be doing ARP on its own (it has to, we might not be using
Ethernet; consider Infiniband for example) then we should be able to
just pass the IP packets to ip_input().

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.