[syslinux] chain.c32 (and partiter) updates v2

[Michal Soltys]

On 2012-11-08 16:43, Shao Miller wrote:
>> On 08.11.2012 02:52, Shao Miller wrote:
>>> On 11/7/2012 20:44, Shao Miller wrote:
>>>> Personally, I'd rather not, but anonymous members of this sort are in
>>>> C11... At least it removes the reserved identifier usage. :)
>>>
>>> What is the benefit? Less typing?
>>>
>>
>> In essence, yes. And with this approach it's as it was originally in
>> your code. For the record, I'm fine with either approach.
>>
>
> The union member was named 'private' at that time, if I'm not mistaken.
>   It's 2012, but I still prefer C89, for portability habits. :)  Would
> it be a huge deal to 'git checkout -b feedback && git rebase -i HEAD~23'
> and drop this?  It might be, if it causes you to have to deal with
> conflicts in the subsequent commits.
>

Ah, the actual field. Indeed it had 'private'. For the record the aim 
was not C11, but some long present gcc extensions (and as -pedantic is 
not set, I assumed it was ok). There is at least one other non-standard 
thingy I used along the way (0b prefixed values). I'll clean that up too.

>
> I hope it's not a big chore as a rebase.  Else, it can be re-introduced
> if and when that day for APM support comes.
>

Nah, not a problem. At least not that tiny part. Some other changes I 
might set at some feedback/correction commit(s) on top.