[syslinux] [PATCH 1/2] Match comment with code
Geert Stappers
stappers at stappers.nl
Sun Dec 15 09:52:45 PST 2013
Op 2013-12-15 om 17:39 schreef Ferenc Wagner:
> Ruben Kerkhof <ruben op rubenkerkhof.com> writes:
>
> > /* 80 00 00 00 ee 00 00 00
> > - - bootable partition, type EFI (EE), no CHS information */
> > + - bootable partition, type EFI (ED), no CHS information */
>
> Please fix the previous comment line as well.
As I understand that, so in _my words_:
Hello Ruben,
Thank you for your patch to the Syslinux project.
You spotted indeed a mismatch between code and comment.
Reviewing your patch revealed other mismatch.
Please rework your patch and submit it again to the mailinglist.
Groeten
Geert Stappers
--
$ git diff -U5 mbr/gptmbr.S
diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S
index 7f450d3..327cfa1 100644
--- a/mbr/gptmbr.S
+++ b/mbr/gptmbr.S
@@ -191,12 +191,12 @@ found_part:
xchgw %ax,%cx /* Set up %cx for rep movsb further down */
movw $dssi_out,%di
pushw %di
- /* 80 00 00 00 ee 00 00 00
- - bootable partition, type EFI (EE), no CHS information */
+ /* 80 00 00 00 ed 00 00 00
+ - bootable partition, type EFI (ED), no CHS information */
xorl %eax,%eax
movb $0x80,%al
stosl
movb $0xed,%al
stosl
More information about the Syslinux
mailing list