[syslinux] Use z size specifier for printf-ing size_t variable

Gene Cumm gene.cumm at gmail.com
Sat Feb 7 04:18:50 PST 2015


On Fri, Feb 6, 2015 at 9:38 AM, Ady via Syslinux <syslinux at zytor.com> wrote:
>
>> On Fri, Feb 6, 2015 at 6:55 AM, Martin Str|mberg <ams at ludd.ltu.se> wrote:
>> > On Sun, Jan 25, 2015 at 06:13:13PM -0200, Raphael S Carvalho wrote:
>> >> On Sat, Nov 22, 2014 at 10:39 AM, Martin Str|mberg <ams at ludd.ltu.se> wrote:
>> >> > Hello.
>> >> >
>> >> > Use the z size specifier to printf-ing size_t variables to get rid of gcc
>> >> > warning
>> >> > format ‘%08x’ expects type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
>> >> Please, add the signed-off line.
>> >
>> > I'm not sure what you want me to do. Should I resend the patch with a
>> > signed-off line?
>> Basically yes, and if you want your patch to be applied.
>>
>> Follow an explanation on why it's important:
>>
>> "12) Sign your work
>
>  (snip)
>
>> then you just add a line saying
>>
>> Signed-off-by: Random J Developer <random at developer.example.org>"
>>
>> Source: /doc/SubmittingPatches
>> >
>> >
>> > --
>> > MartinS
>>
>>
>>
>> --
>> Raphael S. Carvalho
>>
>
> Generally speaking, adequate patches are helpful and desired, and there
> have been cases in which patches have been rejected or inapplicable
> because of inadequate formatting or lack of some information. But, in
> this particular case, AFAIK the patch in question was already applied
> so I would tend to think that there is no need to resend it.

https://github.com/geneC/syslinux/commit/5270b9e01c7f5220c989eff7de3dac7c2ac69dd8
 This same commit ID has been applied on the repository at
git.zytor.com and will be visible once other issues are resolved.

Martin, next time please read doc/SubmittingPatches.txt as it would
also have been helpful if you tagged your email subject appropriately.
It actually helps prevent submissions from seeming to be ignored.

-- 
-Gene



More information about the Syslinux mailing list