[syslinux] boot... round 2

[Thomas Schmitt]

Hi,

hpa wrote:
> On PowerPC (I think) "unsigned char" is the default.

In any case it seems a good idea to interpret the character
more explicitely. To my experience, one signdness change causes
a little tree of consequential signedness changes or questionable
cast operations.
How about the following instead ?

  if ((c >= 0 && c <= ' ') || c == '\x7f') {


Besides code improvement there is the riddle of how gcc 5
can spoil the result.

> gcc does have an -funsigned-char option.

So question to poma:

Can it be that the tested installation of gcc 5 uses this
option by default ?
I read through the mailing list archive but could not
find a mail where you tell the compiler version which
produces working binaries.

Additionally to the different signedness of char, this theory
would also need (unsigned) characters between 128 and 255 in
the SYSAPPEND variables. Is this plausible ?


Have a nice day :)

Thomas