[syslinux] boot... round 2

Gene Cumm gene.cumm at gmail.com
Thu Jul 2 18:51:25 PDT 2015


On Thu, Jul 2, 2015 at 6:14 PM, H. Peter Anvin via Syslinux
<syslinux at zytor.com> wrote:
> On 07/02/2015 02:12 PM, Thomas Schmitt via Syslinux wrote:
>> Hi,
>>
>> hpa wrote:
>>> On PowerPC (I think) "unsigned char" is the default.
>>
>> In any case it seems a good idea to interpret the character
>> more explicitely. To my experience, one signdness change causes
>> a little tree of consequential signedness changes or questionable
>> cast operations.
>> How about the following instead ?
>>
>>   if ((c >= 0 && c <= ' ') || c == '\x7f') {
>>
>
> First of all, this should be an inline instead of being open-coded.  I
> thought we had a myisspace() routine already...

Quick git grep shows isspace() (com32/include/ctype.h:90 and
core/include/ctype.h:25) and my_isspace() (com32/include/menu.h:196)

-- 
-Gene


More information about the Syslinux mailing list