[syslinux] [PATCH] extlinux: code cleanup and simplification

Ady ady-sf at hotmail.com
Wed Nov 25 16:50:36 PST 2015


> On Fri, 13 Nov 2015 20:35:29 +0100
> Nicolas Cornu via Syslinux <syslinux at zytor.com> wrote:
> 
> > Merge btrfs_read_adv and xfs_read_adv into a single generic function
> > ext_read_adv and split ext_write_adv_offset out of ext_write_adv.
> > 
> > Use those new functions in rewrite_boot_image and btrfs_install_file
> > where it is actually hardcoded.
> > 
> > Signed-off-by: Nicolas Cornu <nicolac76 at yahoo.fr>
> > ---
> >  extlinux/main.c | 113
> > +++++++++++++++++++++++++++----------------------------- 1 file
> > changed, 55 insertions(+), 58 deletions(-)
> 
> Applied, thanks.
> 
> Paulo
> 
> -- 
 
I could be wrong but, wasn't there a later set of patches, _replacing_ 
this one? Am I mixing unrelated / independent set of patches?

Also, simplification / unification sometimes might imply that a later 
check / test / review / patch (e.g. for one particular supported 
filesystem, or adding support for a new fs) might be more complicated, 
or might (unwillingly) affect other filesystem support. Am I wrong?

Regards,
Ady.


More information about the Syslinux mailing list