[syslinux] [PATCH] extlinux: code cleanup and simplification

[Celelibi]

2015-11-26 1:50 UTC+01:00, Ady via Syslinux <syslinux at zytor.com>:
>
>> On Fri, 13 Nov 2015 20:35:29 +0100
>> Nicolas Cornu via Syslinux <syslinux at zytor.com> wrote:
>>
>> > Merge btrfs_read_adv and xfs_read_adv into a single generic function
>> > ext_read_adv and split ext_write_adv_offset out of ext_write_adv.
>> >
>> > Use those new functions in rewrite_boot_image and btrfs_install_file
>> > where it is actually hardcoded.
>> >
>> > Signed-off-by: Nicolas Cornu <nicolac76 at yahoo.fr>
>> > ---
>> >  extlinux/main.c | 113
>> > +++++++++++++++++++++++++++----------------------------- 1 file
>> > changed, 55 insertions(+), 58 deletions(-)
>>
>> Applied, thanks.
>>
>> Paulo
>>
>> --
>
> I could be wrong but, wasn't there a later set of patches, _replacing_
> this one? Am I mixing unrelated / independent set of patches?

This is the right one.

>
> Also, simplification / unification sometimes might imply that a later
> check / test / review / patch (e.g. for one particular supported
> filesystem, or adding support for a new fs) might be more complicated,
> or might (unwillingly) affect other filesystem support. Am I wrong?

In general, they might. But the installers look a bit messy at the
time and can only benefit from a bit of simplification.


Celelibi