[syslinux] [PATCH] core/lwip: Avoid immediate reuse of UDP port numbers

Gene Cumm gene.cumm at gmail.com
Tue Jul 5 03:43:34 PDT 2016


On Mon, Jul 4, 2016 at 6:34 AM, Michael Brown via Syslinux
<syslinux at zytor.com> wrote:
> On 04/07/16 09:35, Michael Brown wrote:
>>
>> The UDP binding logic will reuse local port numbers immediately.  This
>> causes problems for TFTP, which assumes a very low probability of a
>> source port number being reused.  The consequence is that lpxelinux.0
>> may end up downloading an incorrect file (e.g. attempting to download
>> pxelinux.cfg/default but actually receiving a copy of ldlinux.c32, due
>> to the port number having been reused).
>>
>> Fix by allocating local UDP port numbers in the same way as local TCP
>> port numbers.
>
>
> An equivalent patch for this already exists in upstream lwIP.

I've marked both for review.  Thanks.  These seem very relevant to
some of the reported issues.

-- 
-Gene


More information about the Syslinux mailing list